Commit Graph
100 Commits
Author SHA1 Message Date
kibigo!andClaire 2cabc5d188 Use a tree‐based approach for advanced text formatting (#1907)
* Use a tree‐based approach for adv. text formatting

Sanitizing HTML/Markdown means parsing the content into an HTML tree
under‐the‐hood anyway, and it is more accurate to do mention/hashtag
replacement on the text nodes in that tree than it is to try to hack it
in with regexes et cetera.

This undoes the overrides of `#entities` and `#rewrite` on
`AdvancedTextFormatter` but also stops using them, instead keeping
track of the parsed Nokogiri tree itself and using that in the `#to_s`
method.

Internally, this tree uses `<mastodon-entity>` nodes to keep track of
hashtags, links, and mentions. Sanitization is moved to the beginning,
so it should be known that these do not appear in the input.

* Also disallow entities inside of `<code>`

I think this is generally expected behaviour, and people are annoyed
when their code gets turned into links/hashtags/mentions.

* Minor cleanup to AdvancedTextFormatter

* Change AdvancedTextFormatter to rewrite entities in one pass and sanitize at the end

Also, minor refactoring to better match how other formatters are organized.

* Add some tests

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2022-12-02 10:29:42 +01:00
Gô Shoemake 22f2750578 Merge pull request #384 from ThibG/glitch-soc/features/no-media-url
Remove text requirement when media attached from statuses (fixes #381)
2018-03-12 13:09:42 -07:00
Gô Shoemake 2395a4c313 Merge pull request #344 from chriswmartin/getting-started-badge-merge
merge tootsuite pr #6313 into glitch & move getting_started dispatch stuff to mapDispatchToProps
2018-03-12 13:07:59 -07:00
kibi! 60ff086960 Fixed improper mailer import 2018-01-15 21:23:26 -08:00
kibi! cda845ae0e Fix mailer to use webpack core 2018-01-15 21:17:03 -08:00
Gô Shoemake 08e4c78e78 Fix column headers accessibility (#6199)
* Fix accessibility of column headers

As a screen reader user new to Mastodon, I encountered the following issues with the column headers as designed:
 * Jumping between them was difficult. FOr instance, passing my home timeline to reach notification settings was difficult to impossible, especially considering infinite scrolling.
 * There doesn't appear to be any means for triggering the control via the keyboard. the `titleClick` handler only responds to mouse clicks.
 * I didn't even realize there was a Settings toggle until I made this change.

Thanks for using ARIA in your designs. It's a huge help. But adding a `button` role doesn't add keyboard handling and other button behavior. Also, because the role was on the heading container, it obscured the controls within the container itself. This fix resolve that. It also exposes the headings as headings rather than buttons, enabling skipping columns by using screen readers' heading navigation commands.

Since I myself am blind, if this fix requires additional visual styling, I'd like help applying that so it can be merged. I'd consider it an essential accessibility fix for my and other blind users' existence on the platform. Thanks!

* Styling fixes

* Fixed overflow issue
2018-01-15 04:33:06 +01:00
kibi! 8ee6ed358f Increase priority of favstar gold 2018-01-14 16:05:44 -08:00
kibi! 1ee0e91fb6 Fixes to notification styling 2018-01-14 15:48:54 -08:00
kibi! b9f4896830 Fixes to drawer and CWs 2018-01-14 15:31:00 -08:00
kibi! 0fb3bd09e9 Oops this should have been a part of last commit 2018-01-14 14:21:41 -08:00
kibi! 1fa03e026a Fixes onboarding modal (#318) 2018-01-14 14:13:24 -08:00
kibi! a5931e1f48 Fixed autocollapse detection 2018-01-14 13:29:51 -08:00
Gô Shoemake 3a0b47982d load public.js on vanilla#admin 2018-01-12 18:52:53 -08:00
Gô Shoemake 9b9b7fa005 Load packs/public.js for glitch#admin 2018-01-12 18:51:52 -08:00
kibigo! 35be02f21d Renamed glitch async chunks 2018-01-09 16:26:14 -08:00
kibigo! 60433d03f5 Add missing comma 2018-01-08 18:38:28 -08:00
kibigo! 5d2ef7a616 Show SENSITIVE tag on sensitive images (#267) 2018-01-08 18:25:29 -08:00
kibigo! 44792de49a Don't show skins selector when there's only one (#256) 2018-01-08 16:45:32 -08:00
kibigo! 824a790e63 Threads now inherit privacy directly (#309) 2018-01-08 16:35:01 -08:00
kibigo! b5874c1428 Fixes to search dropdown 2018-01-06 15:34:01 -08:00
kibigo! c71d848855 my global .gitignore excluded this file ;_; 2018-01-05 21:40:02 -08:00
kibigo! e4bc013d6f Threaded mode~ 2018-01-05 21:16:43 -08:00
kibigo! 6932b464e6 Fixed improper dropdown func binding for #293 + toot button spacing 2018-01-05 21:02:53 -08:00
kibigo! ad10a80a99 Styling and autosuggest fixes for #293 2018-01-05 20:43:16 -08:00
kibigo! 8bf9d9362a Fixes composer mounting issue with #293 2018-01-05 18:30:06 -08:00
kibigo! ac686d5a5d Fixed overflow issue 2018-01-05 13:34:21 -08:00
kibigo! ec620ae486 Styling fixes 2018-01-05 12:41:15 -08:00
kibigo! d7ce339c2e WIP <Compose> Refactor; Fin~ 2018-01-04 21:17:30 -08:00
kibigo! 42f50049ff WIP <Compose> Refactor; 1000 tiny edits 2018-01-04 18:33:13 -08:00
kibigo! b4a3792201 WIP <Compose> Refactor; <ActionsModal>; dropdowns 2018-01-04 18:31:00 -08:00
kibigo! 083170bec7 WIP <Compose> Refactor; SCSS ed. 2018-01-04 18:23:46 -08:00
kibigo! 8713659dff WIP <Compose> Refactor; <OnboardingModal> ed. 2018-01-04 18:21:59 -08:00
kibigo! 3c29f57404 WIP <Compose> Refactor; <Drawer> ed. 2018-01-04 18:21:59 -08:00
kibigo! 924ffe81d4 WIPgit status <Compose> Refactor; <Composer> ed. 2018-01-04 18:21:59 -08:00
kibigo! e677dda07c Fixes #244 to make search results scrollable 2017-12-15 12:49:23 -08:00
Gô Shoemake 04eaa1943f Merge pull request #262 from chriswmartin/fix-oauth-pack
Add missing set pack to authorizations_controller
2017-12-11 19:34:19 -08:00
kibigo! 8aa527434c Fixed index in webpack config 2017-12-11 10:45:21 -08:00
kibigo! ed7231947c Added styling 2017-12-10 20:32:28 -08:00
kibigo! bdca1614d5 Screenshot support for themes 2017-12-10 20:32:28 -08:00
kibigo! dabf66e676 Moved flavour UI into own prefs tab 2017-12-10 20:32:27 -08:00
kibigo! 64b839b769 Removed MORE theme localizns 2017-12-10 11:38:30 -08:00
kibigo! cd107e92cb Move ja localization to new locaiton 2017-12-10 11:09:59 -08:00
kibigo! 6b7085a33e Linting fixes 2017-12-10 11:08:04 -08:00
kibigo! 1c728df92e Only localize js when there's a theme 2017-12-10 11:08:04 -08:00
kibigo! b28cd6769c Javascript intl8n flavour support 2017-12-10 11:08:04 -08:00
kibigo! 8394430081 Removed unused theme localization key 2017-12-10 11:08:04 -08:00
kibigo! d08d0f9f33 Ruby intl8n for themes 2017-12-10 11:08:04 -08:00
kibigo! 717b7d555c Skins shouldn't apply to fallback flavours 2017-12-07 14:49:54 -08:00
kibigo! 753535c3c7 Fixed webpack skin folder globbing 2017-12-07 14:33:49 -08:00
kibigo! 9cdd81e9dd Glitch doesn't have a home stylesheet anymore 2017-12-07 14:32:52 -08:00
kibigo! 96126a5b01 Packaged local_settings styles in common 2017-12-07 13:36:18 -08:00
kibigo! 2f2467ce8e Add option to remove DMs from home (#126) 2017-12-06 17:50:27 -08:00
kibigo! 061211a1e3 Fix common packs when other pack also there 2017-12-06 15:34:19 -08:00
kibigo! 5bed0f10ed Various fixes 2017-12-04 21:58:10 -08:00
kibigo! 1c74ede69e Fixed a name + localizations 2017-12-04 00:19:39 -08:00
kibigo! 7c75702d05 Fixed image require 2017-12-03 23:52:13 -08:00
kibigo! bc4fa6b198 Rename themes -> flavours ? ? 2017-12-03 23:26:40 -08:00
kibigo! d216547382 Fixed typos 2017-12-03 22:30:45 -08:00
kibigo! 541fe9b110 Skins support 2017-11-30 19:29:47 -08:00
kibigo! 6a48efe16c Adds spoiler hotkey support to detailed statuses 2017-11-27 14:05:03 -08:00
kibigo! f3c3df62ab Implement status hotkeys + spoiler expanding 2017-11-27 13:30:01 -08:00
kibigo! 2585649b20 Styling fixes 2017-11-21 19:00:07 -08:00
kibigo! 12c0011fee Update statuses on hidden toggle (Fixes #227) 2017-11-21 18:27:34 -08:00
kibigo! 8812bab687 Minor fixes 2017-11-21 18:17:38 -08:00
kibigo! bdbbd06dad Finalized theme loading and stuff 2017-11-20 22:13:37 -08:00
kibigo! 321fa41930 Merge remote-tracking branch 'cybre/theme_win95' into glitch-theme 2017-11-18 15:18:00 -08:00
kibigo! a9ed857171 WIP static themeing 2017-11-18 15:12:52 -08:00
kibigo! 92cc79be72 Enabled vanilla thmee 2017-11-18 11:06:04 -08:00
kibigo! 08a01dd037 Public pack fix 2017-11-18 11:05:39 -08:00
kibigo! 672ace5a20 Media styling 2017-11-18 11:05:23 -08:00
kibigo! f51f7b0e06 Font styles are now packagified 2017-11-18 11:05:00 -08:00
kibigo! a618df7998 Sets default theme to glitch 2017-11-17 19:32:04 -08:00
kibigo! fc2c8b50dd Removed glitch tests 2017-11-17 19:29:17 -08:00
kibigo! e19fc6a9f8 Restore vanilla components 2017-11-17 19:29:16 -08:00
kibigo! 45c44989c8 Forking glitch theme 2017-11-17 19:29:16 -08:00
kibigo! 4dd19054d6 Removes spin theme 2017-11-16 21:54:12 -08:00
kibigo! 585758a373 Themed prefetching 2017-11-16 21:37:08 -08:00
kibigo! bc8532359b Mastodon GO! -> v0.1.1 2017-11-06 20:00:03 -08:00
kibigo! e0298d66f8 Autocollapse boosts option 2017-11-05 15:05:12 -08:00
kibigo! 276432790a Introducing: Mastodon GO! 2017-11-04 05:48:42 -07:00
kibigo! 119d477c8b Added app/javascript for imports 2017-10-23 20:22:48 -07:00
kibigo! 21bafc6555 Updates to bio metadata script 2017-10-19 16:11:53 -07:00
kibigo! 3cc6255a7e Removed length check which now happens in reducer 2017-10-11 11:50:11 -07:00
kibigo! 35e2cad4eb Fixed header emojification 2017-10-11 11:00:28 -07:00
kibigo! 8d6b9ba494 Merge upstream 2.0ish #165 2017-10-11 10:43:10 -07:00
kibigo! 6610d57f91 Basic static metadata styling 2017-10-06 22:22:34 -07:00
kibigo! 53f829dfa8 HAML fix 2017-09-28 18:16:04 -07:00
kibigo! cf1f83ca2a Fixed lingering upstream Theme code 2017-09-28 17:45:16 -07:00
kibigo! 1522795853 new HAML for statuses 2017-09-28 17:18:12 -07:00
kibigo! f7ca205f38 Fixed webpack config code 2017-09-25 19:35:54 -07:00
kibigo! 86e617a839 Better themeing support!! 2017-09-25 19:24:32 -07:00
kibigo! c2b479efec Long display names now ellipsis properly 2017-09-21 16:55:32 -07:00
kibigo! a94dc21c79 Styling fixes for header redesign 2017-09-21 16:46:18 -07:00
kibigo! 9ed51cecd0 Fixed notification appearance 2017-09-20 14:52:01 -07:00
kibigo! 15c9c2fd7e Pinned toots; embeds 2017-09-20 02:50:53 -07:00
kibigo! 227dbb6adb Added GIF hover-to-play support 2017-09-20 02:19:36 -07:00
kibigo! 769f62d96f Improvements to status headers 2017-09-20 01:57:08 -07:00
kibigo! 003bfd094e Fixed disabled boost SVG (#106) 2017-09-20 00:40:54 -07:00
kibigo! fae8dce738 Fixed #133 (only parse links in status text) 2017-09-20 00:20:11 -07:00
kibigo! 70c5eccc12 Compatibility regex for user profiles 2017-08-06 15:10:06 -07:00