Ignore undefined as canonical url (#31882)

This commit is contained in:
David Roetzel authored and GitHub committed 2024-09-12 11:14:42 +00:00
1 parent 3d46f47817
commit ab763c493f
2 files changed
+9 -1

No files matched your search

+1 -1
View File
@@ -225,7 +225,7 @@ class LinkDetailsExtractor
end
def valid_url_or_nil(str, same_origin_only: false)
return if str.blank? || str == 'null'
return if str.blank? || str == 'null' || str == 'undefined'
url = @original_url + Addressable::URI.parse(str)
+8
View File
@@ -33,6 +33,14 @@ RSpec.describe LinkDetailsExtractor do
expect(subject.canonical_url).to eq original_url
end
end
context 'when canonical URL is set to "undefined"' do
let(:url) { 'undefined' }
it 'ignores the canonical URLs' do
expect(subject.canonical_url).to eq original_url
end
end
end
context 'when only basic metadata is present' do