e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
47 lines
1.2 KiB
Ruby
47 lines
1.2 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe AuthorizeFollowService, type: :service do
|
|
let(:sender) { Fabricate(:account, username: 'alice') }
|
|
|
|
subject { AuthorizeFollowService.new }
|
|
|
|
describe 'local' do
|
|
let(:bob) { Fabricate(:account, username: 'bob') }
|
|
|
|
before do
|
|
FollowRequest.create(account: bob, target_account: sender)
|
|
subject.call(bob, sender)
|
|
end
|
|
|
|
it 'removes follow request' do
|
|
expect(bob.requested?(sender)).to be false
|
|
end
|
|
|
|
it 'creates follow relation' do
|
|
expect(bob.following?(sender)).to be true
|
|
end
|
|
end
|
|
|
|
describe 'remote ActivityPub' do
|
|
let(:bob) { Fabricate(:account, username: 'bob', domain: 'example.com', protocol: :activitypub, inbox_url: 'http://example.com/inbox') }
|
|
|
|
before do
|
|
FollowRequest.create(account: bob, target_account: sender)
|
|
stub_request(:post, bob.inbox_url).to_return(status: 200)
|
|
subject.call(bob, sender)
|
|
end
|
|
|
|
it 'removes follow request' do
|
|
expect(bob.requested?(sender)).to be false
|
|
end
|
|
|
|
it 'creates follow relation' do
|
|
expect(bob.following?(sender)).to be true
|
|
end
|
|
|
|
it 'sends an accept activity' do
|
|
expect(a_request(:post, bob.inbox_url)).to have_been_made.once
|
|
end
|
|
end
|
|
end
|