* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			94 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			94 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
require 'rails_helper'
 | 
						|
 | 
						|
describe Api::V1::Accounts::RelationshipsController do
 | 
						|
  render_views
 | 
						|
 | 
						|
  let(:user)  { Fabricate(:user) }
 | 
						|
  let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:follows') }
 | 
						|
 | 
						|
  before do
 | 
						|
    allow(controller).to receive(:doorkeeper_token) { token }
 | 
						|
  end
 | 
						|
 | 
						|
  describe 'GET #index' do
 | 
						|
    let(:simon) { Fabricate(:account) }
 | 
						|
    let(:lewis) { Fabricate(:account) }
 | 
						|
 | 
						|
    before do
 | 
						|
      user.account.follow!(simon)
 | 
						|
      lewis.follow!(user.account)
 | 
						|
    end
 | 
						|
 | 
						|
    context 'provided only one ID' do
 | 
						|
      before do
 | 
						|
        get :index, params: { id: simon.id }
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns http success' do
 | 
						|
        expect(response).to have_http_status(200)
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns JSON with correct data' do
 | 
						|
        json = body_as_json
 | 
						|
 | 
						|
        expect(json).to be_a Enumerable
 | 
						|
        expect(json.first[:following]).to be true
 | 
						|
        expect(json.first[:followed_by]).to be false
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    context 'provided multiple IDs' do
 | 
						|
      before do
 | 
						|
        get :index, params: { id: [simon.id, lewis.id] }
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns http success' do
 | 
						|
        expect(response).to have_http_status(200)
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns JSON with correct data' do
 | 
						|
        json = body_as_json
 | 
						|
 | 
						|
        expect(json).to be_a Enumerable
 | 
						|
        expect(json.first[:id]).to eq simon.id.to_s
 | 
						|
        expect(json.first[:following]).to be true
 | 
						|
        expect(json.first[:showing_reblogs]).to be true
 | 
						|
        expect(json.first[:followed_by]).to be false
 | 
						|
        expect(json.first[:muting]).to be false
 | 
						|
        expect(json.first[:requested]).to be false
 | 
						|
        expect(json.first[:domain_blocking]).to be false
 | 
						|
 | 
						|
        expect(json.second[:id]).to eq lewis.id.to_s
 | 
						|
        expect(json.second[:following]).to be false
 | 
						|
        expect(json.second[:showing_reblogs]).to be false
 | 
						|
        expect(json.second[:followed_by]).to be true
 | 
						|
        expect(json.second[:muting]).to be false
 | 
						|
        expect(json.second[:requested]).to be false
 | 
						|
        expect(json.second[:domain_blocking]).to be false
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns JSON with correct data on cached requests too' do
 | 
						|
        get :index, params: { id: [simon.id] }
 | 
						|
 | 
						|
        json = body_as_json
 | 
						|
 | 
						|
        expect(json).to be_a Enumerable
 | 
						|
        expect(json.first[:following]).to be true
 | 
						|
        expect(json.first[:showing_reblogs]).to be true
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns JSON with correct data after change too' do
 | 
						|
        user.account.unfollow!(simon)
 | 
						|
 | 
						|
        get :index, params: { id: [simon.id] }
 | 
						|
 | 
						|
        json = body_as_json
 | 
						|
 | 
						|
        expect(json).to be_a Enumerable
 | 
						|
        expect(json.first[:following]).to be false
 | 
						|
        expect(json.first[:showing_reblogs]).to be false
 | 
						|
      end
 | 
						|
    end
 | 
						|
  end
 | 
						|
end
 |