* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			64 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			64 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| require 'rails_helper'
 | |
| 
 | |
| describe Api::V1::Accounts::FollowerAccountsController do
 | |
|   render_views
 | |
| 
 | |
|   let(:user)    { Fabricate(:user) }
 | |
|   let(:token)   { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:accounts') }
 | |
|   let(:account) { Fabricate(:account) }
 | |
|   let(:alice)   { Fabricate(:account) }
 | |
|   let(:bob)     { Fabricate(:account) }
 | |
| 
 | |
|   before do
 | |
|     alice.follow!(account)
 | |
|     bob.follow!(account)
 | |
|     allow(controller).to receive(:doorkeeper_token) { token }
 | |
|   end
 | |
| 
 | |
|   describe 'GET #index' do
 | |
|     it 'returns http success' do
 | |
|       get :index, params: { account_id: account.id, limit: 2 }
 | |
| 
 | |
|       expect(response).to have_http_status(200)
 | |
|     end
 | |
| 
 | |
|     it 'returns accounts following the given account' do
 | |
|       get :index, params: { account_id: account.id, limit: 2 }
 | |
| 
 | |
|       expect(body_as_json.size).to eq 2
 | |
|       expect([body_as_json[0][:id], body_as_json[1][:id]]).to match_array([alice.id.to_s, bob.id.to_s])
 | |
|     end
 | |
| 
 | |
|     it 'does not return blocked users' do
 | |
|       user.account.block!(bob)
 | |
|       get :index, params: { account_id: account.id, limit: 2 }
 | |
| 
 | |
|       expect(body_as_json.size).to eq 1
 | |
|       expect(body_as_json[0][:id]).to eq alice.id.to_s
 | |
|     end
 | |
| 
 | |
|     context 'when requesting user is blocked' do
 | |
|       before do
 | |
|         account.block!(user.account)
 | |
|       end
 | |
| 
 | |
|       it 'hides results' do
 | |
|         get :index, params: { account_id: account.id, limit: 2 }
 | |
|         expect(body_as_json.size).to eq 0
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'when requesting user is the account owner' do
 | |
|       let(:user) { account.user }
 | |
| 
 | |
|       it 'returns all accounts, including muted accounts' do
 | |
|         account.mute!(bob)
 | |
|         get :index, params: { account_id: account.id, limit: 2 }
 | |
| 
 | |
|         expect(body_as_json.size).to eq 2
 | |
|         expect([body_as_json[0][:id], body_as_json[1][:id]]).to match_array([alice.id.to_s, bob.id.to_s])
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |