There are edge cases where requests to certain hosts timeout when using the vanilla HTTP.rb gem, which the goldfinger gem uses. Now that we no longer need to support OStatus servers, webfinger logic is so simple that there is no point encapsulating it in a gem, so we can just use our own Request class. With that, we benefit from more robust timeout code and IPv4/IPv6 resolution. Fix #14091
		
			
				
	
	
		
			67 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			67 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| class ActivityPub::FetchRemoteAccountService < BaseService
 | |
|   include JsonLdHelper
 | |
|   include DomainControlHelper
 | |
|   include WebfingerHelper
 | |
| 
 | |
|   SUPPORTED_TYPES = %w(Application Group Organization Person Service).freeze
 | |
| 
 | |
|   # Does a WebFinger roundtrip on each call, unless `only_key` is true
 | |
|   def call(uri, id: true, prefetched_body: nil, break_on_redirect: false, only_key: false)
 | |
|     return if domain_not_allowed?(uri)
 | |
|     return ActivityPub::TagManager.instance.uri_to_resource(uri, Account) if ActivityPub::TagManager.instance.local_uri?(uri)
 | |
| 
 | |
|     @json = begin
 | |
|       if prefetched_body.nil?
 | |
|         fetch_resource(uri, id)
 | |
|       else
 | |
|         body_to_json(prefetched_body, compare_id: id ? uri : nil)
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     return if !supported_context? || !expected_type? || (break_on_redirect && @json['movedTo'].present?)
 | |
| 
 | |
|     @uri      = @json['id']
 | |
|     @username = @json['preferredUsername']
 | |
|     @domain   = Addressable::URI.parse(@uri).normalized_host
 | |
| 
 | |
|     return unless only_key || verified_webfinger?
 | |
| 
 | |
|     ActivityPub::ProcessAccountService.new.call(@username, @domain, @json, only_key: only_key)
 | |
|   rescue Oj::ParseError
 | |
|     nil
 | |
|   end
 | |
| 
 | |
|   private
 | |
| 
 | |
|   def verified_webfinger?
 | |
|     webfinger                            = webfinger!("acct:#{@username}@#{@domain}")
 | |
|     confirmed_username, confirmed_domain = split_acct(webfinger.subject)
 | |
| 
 | |
|     return webfinger.link('self', 'href') == @uri if @username.casecmp(confirmed_username).zero? && @domain.casecmp(confirmed_domain).zero?
 | |
| 
 | |
|     webfinger                            = webfinger!("acct:#{confirmed_username}@#{confirmed_domain}")
 | |
|     @username, @domain                   = split_acct(webfinger.subject)
 | |
| 
 | |
|     return false unless @username.casecmp(confirmed_username).zero? && @domain.casecmp(confirmed_domain).zero?
 | |
|     return false if webfinger.link('self', 'href') != @uri
 | |
| 
 | |
|     true
 | |
|   rescue Webfinger::Error
 | |
|     false
 | |
|   end
 | |
| 
 | |
|   def split_acct(acct)
 | |
|     acct.gsub(/\Aacct:/, '').split('@')
 | |
|   end
 | |
| 
 | |
|   def supported_context?
 | |
|     super(@json)
 | |
|   end
 | |
| 
 | |
|   def expected_type?
 | |
|     equals_or_includes_any?(@json['type'], SUPPORTED_TYPES)
 | |
|   end
 | |
| end
 |