* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			38 lines
		
	
	
		
			961 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			38 lines
		
	
	
		
			961 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
require 'rails_helper'
 | 
						|
 | 
						|
RSpec.describe Api::V1::ConversationsController, type: :controller do
 | 
						|
  render_views
 | 
						|
 | 
						|
  let!(:user) { Fabricate(:user, account_attributes: { username: 'alice' }) }
 | 
						|
  let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
 | 
						|
  let(:other) { Fabricate(:user) }
 | 
						|
 | 
						|
  before do
 | 
						|
    allow(controller).to receive(:doorkeeper_token) { token }
 | 
						|
  end
 | 
						|
 | 
						|
  describe 'GET #index' do
 | 
						|
    let(:scopes) { 'read:statuses' }
 | 
						|
 | 
						|
    before do
 | 
						|
      PostStatusService.new.call(other.account, text: 'Hey @alice', visibility: 'direct')
 | 
						|
    end
 | 
						|
 | 
						|
    it 'returns http success' do
 | 
						|
      get :index
 | 
						|
      expect(response).to have_http_status(200)
 | 
						|
    end
 | 
						|
 | 
						|
    it 'returns pagination headers' do
 | 
						|
      get :index, params: { limit: 1 }
 | 
						|
      expect(response.headers['Link'].links.size).to eq(2)
 | 
						|
    end
 | 
						|
 | 
						|
    it 'returns conversations' do
 | 
						|
      get :index
 | 
						|
      json = body_as_json
 | 
						|
      expect(json.size).to eq 1
 | 
						|
    end
 | 
						|
  end
 | 
						|
end
 |