* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			25 lines
		
	
	
		
			507 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			25 lines
		
	
	
		
			507 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| require 'rails_helper'
 | |
| require 'pundit/rspec'
 | |
| 
 | |
| RSpec.describe RelayPolicy do
 | |
|   let(:subject) { described_class }
 | |
|   let(:admin)   { Fabricate(:user, admin: true).account }
 | |
|   let(:john)    { Fabricate(:account) }
 | |
| 
 | |
|   permissions :update? do
 | |
|     context 'admin?' do
 | |
|       it 'permits' do
 | |
|         expect(subject).to permit(admin, Relay)
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context '!admin?' do
 | |
|       it 'denies' do
 | |
|         expect(subject).to_not permit(john, Relay)
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |