* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			47 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			47 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
# frozen_string_literal: true
 | 
						|
 | 
						|
require 'rails_helper'
 | 
						|
 | 
						|
RSpec.describe Api::V1::Accounts::PinsController, type: :controller do
 | 
						|
  let(:john)  { Fabricate(:user) }
 | 
						|
  let(:kevin) { Fabricate(:user) }
 | 
						|
  let(:token) { Fabricate(:accessible_access_token, resource_owner_id: john.id, scopes: 'write:accounts') }
 | 
						|
 | 
						|
  before do
 | 
						|
    kevin.account.followers << john.account
 | 
						|
    allow(controller).to receive(:doorkeeper_token) { token }
 | 
						|
  end
 | 
						|
 | 
						|
  describe 'POST #create' do
 | 
						|
    subject { post :create, params: { account_id: kevin.account.id } }
 | 
						|
 | 
						|
    it 'returns 200' do
 | 
						|
      expect(response).to have_http_status(200)
 | 
						|
    end
 | 
						|
 | 
						|
    it 'creates account_pin' do
 | 
						|
      expect do
 | 
						|
        subject
 | 
						|
      end.to change { AccountPin.where(account: john.account, target_account: kevin.account).count }.by(1)
 | 
						|
    end
 | 
						|
  end
 | 
						|
 | 
						|
  describe 'DELETE #destroy' do
 | 
						|
    subject { delete :destroy, params: { account_id: kevin.account.id } }
 | 
						|
 | 
						|
    before do
 | 
						|
      Fabricate(:account_pin, account: john.account, target_account: kevin.account)
 | 
						|
    end
 | 
						|
 | 
						|
    it 'returns 200' do
 | 
						|
      expect(response).to have_http_status(200)
 | 
						|
    end
 | 
						|
 | 
						|
    it 'destroys account_pin' do
 | 
						|
      expect do
 | 
						|
        subject
 | 
						|
      end.to change { AccountPin.where(account: john.account, target_account: kevin.account).count }.by(-1)
 | 
						|
    end
 | 
						|
  end
 | 
						|
end
 |