[Glitch] Fix controls for unchangeable properties on status edit not being disabled
Port 38845592c4b4456b5b407bd320249613a0f16e13 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
This commit is contained in:
		
							parent
							
								
									c9669ee167
								
							
						
					
					
						commit
						f3429d7354
					
				@ -355,6 +355,7 @@ class ComposeForm extends ImmutablePureComponent {
 | 
			
		||||
            onToggleSpoiler={spoilersAlwaysOn ? null : onChangeSpoilerness}
 | 
			
		||||
            onUpload={onPaste}
 | 
			
		||||
            privacy={privacy}
 | 
			
		||||
            isEditing={isEditing}
 | 
			
		||||
            sensitive={sensitive || (spoilersAlwaysOn && spoilerText && spoilerText.length > 0)}
 | 
			
		||||
            spoiler={spoilersAlwaysOn ? (spoilerText && spoilerText.length > 0) : spoiler}
 | 
			
		||||
          />
 | 
			
		||||
 | 
			
		||||
@ -138,6 +138,7 @@ class ComposerOptions extends ImmutablePureComponent {
 | 
			
		||||
    resetFileKey: PropTypes.number,
 | 
			
		||||
    spoiler: PropTypes.bool,
 | 
			
		||||
    showContentTypeChoice: PropTypes.bool,
 | 
			
		||||
    isEditing: PropTypes.bool,
 | 
			
		||||
  };
 | 
			
		||||
 | 
			
		||||
  //  Handles file selection.
 | 
			
		||||
@ -202,6 +203,7 @@ class ComposerOptions extends ImmutablePureComponent {
 | 
			
		||||
      resetFileKey,
 | 
			
		||||
      spoiler,
 | 
			
		||||
      showContentTypeChoice,
 | 
			
		||||
      isEditing,
 | 
			
		||||
      intl: { formatMessage },
 | 
			
		||||
    } = this.props;
 | 
			
		||||
 | 
			
		||||
@ -273,7 +275,7 @@ class ComposerOptions extends ImmutablePureComponent {
 | 
			
		||||
        )}
 | 
			
		||||
        <hr />
 | 
			
		||||
        <PrivacyDropdown
 | 
			
		||||
          disabled={disabled}
 | 
			
		||||
          disabled={disabled || isEditing}
 | 
			
		||||
          onChange={onChangeVisibility}
 | 
			
		||||
          onModalClose={onModalClose}
 | 
			
		||||
          onModalOpen={onModalOpen}
 | 
			
		||||
@ -306,7 +308,7 @@ class ComposerOptions extends ImmutablePureComponent {
 | 
			
		||||
        )}
 | 
			
		||||
        <Dropdown
 | 
			
		||||
          active={advancedOptions && advancedOptions.some(value => !!value)}
 | 
			
		||||
          disabled={disabled}
 | 
			
		||||
          disabled={disabled || isEditing}
 | 
			
		||||
          icon='ellipsis-h'
 | 
			
		||||
          items={advancedOptions ? [
 | 
			
		||||
            {
 | 
			
		||||
 | 
			
		||||
@ -27,6 +27,7 @@ class PrivacyDropdown extends React.PureComponent {
 | 
			
		||||
    onChange: PropTypes.func.isRequired,
 | 
			
		||||
    noDirect: PropTypes.bool,
 | 
			
		||||
    container: PropTypes.func,
 | 
			
		||||
    disabled: PropTypes.bool,
 | 
			
		||||
    intl: PropTypes.object.isRequired,
 | 
			
		||||
  };
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
@ -19,6 +19,7 @@ export default class Upload extends ImmutablePureComponent {
 | 
			
		||||
    media: ImmutablePropTypes.map.isRequired,
 | 
			
		||||
    onUndo: PropTypes.func.isRequired,
 | 
			
		||||
    onOpenFocalPoint: PropTypes.func.isRequired,
 | 
			
		||||
    isEditingStatus: PropTypes.func.isRequired,
 | 
			
		||||
  };
 | 
			
		||||
 | 
			
		||||
  handleUndoClick = e => {
 | 
			
		||||
@ -32,7 +33,7 @@ export default class Upload extends ImmutablePureComponent {
 | 
			
		||||
  }
 | 
			
		||||
 | 
			
		||||
  render () {
 | 
			
		||||
    const { intl, media } = this.props;
 | 
			
		||||
    const { intl, media, isEditingStatus } = this.props;
 | 
			
		||||
    const focusX = media.getIn(['meta', 'focus', 'x']);
 | 
			
		||||
    const focusY = media.getIn(['meta', 'focus', 'y']);
 | 
			
		||||
    const x = ((focusX /  2) + .5) * 100;
 | 
			
		||||
@ -45,7 +46,7 @@ export default class Upload extends ImmutablePureComponent {
 | 
			
		||||
            <div style={{ transform: `scale(${scale})`, backgroundImage: `url(${media.get('preview_url')})`, backgroundPosition: `${x}% ${y}%` }}>
 | 
			
		||||
              <div className={classNames('composer--upload_form--actions', { active: true })}>
 | 
			
		||||
                <button className='icon-button' onClick={this.handleUndoClick}><Icon id='times' /> <FormattedMessage id='upload_form.undo' defaultMessage='Delete' /></button>
 | 
			
		||||
                <button className='icon-button' onClick={this.handleFocalPointClick}><Icon id='pencil' /> <FormattedMessage id='upload_form.edit' defaultMessage='Edit' /></button>
 | 
			
		||||
                {!isEditingStatus && (<button className='icon-button' onClick={this.handleFocalPointClick}><Icon id='pencil' /> <FormattedMessage id='upload_form.edit' defaultMessage='Edit' /></button>)}
 | 
			
		||||
              </div>
 | 
			
		||||
            </div>
 | 
			
		||||
          )}
 | 
			
		||||
 | 
			
		||||
@ -5,6 +5,7 @@ import { submitCompose } from 'flavours/glitch/actions/compose';
 | 
			
		||||
 | 
			
		||||
const mapStateToProps = (state, { id }) => ({
 | 
			
		||||
  media: state.getIn(['compose', 'media_attachments']).find(item => item.get('id') === id),
 | 
			
		||||
  isEditingStatus: state.getIn(['compose', 'id']) !== null,
 | 
			
		||||
});
 | 
			
		||||
 | 
			
		||||
const mapDispatchToProps = dispatch => ({
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user