tarrien/Mastodon
1
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix order of paginated accounts in FollowerDomainsController and spec (#3357)

Browse Source 
* Fix order of paginated accounts in FollowerDomainsController

Unordered pagination could result in unexpected behavior.

* Cover Settings::FollowerDomainsController more
This commit is contained in:
Akihiko Odaki authored and Eugen Rochko committed 2017-09-30 23:06:09 +02:00
1 parent eb605141ff
commit cdacac8c6c
2 files changed
+59 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

app/controllers/settings/follower_domains_controller.rb
+1 -1
View File
@@ -9,7 +9,7 @@ class Settings::FollowerDomainsController < ApplicationController
def show
@account = current_account
@domains = current_account.followers.reorder(nil).group('accounts.domain').select('accounts.domain, count(accounts.id) as accounts_from_domain').page(params[:page]).per(10)
@domains = current_account.followers.reorder('MIN(follows.id) DESC').group('accounts.domain').select('accounts.domain, count(accounts.id) as accounts_from_domain').page(params[:page]).per(10)
end
def update