Fix RSpec/AnyInstance cop (#27810)
This commit is contained in:
1 parent
d562fb8459
commit
b2c5b20ef2
14 files changed
+70
-60
No files matched your search
@@ -209,9 +209,13 @@ RSpec.describe Account do
|
||||
expect(account.refresh!).to be_nil
|
||||
end
|
||||
|
||||
it 'calls not ResolveAccountService#call' do
|
||||
expect_any_instance_of(ResolveAccountService).to_not receive(:call).with(acct)
|
||||
it 'does not call ResolveAccountService#call' do
|
||||
service = instance_double(ResolveAccountService, call: nil)
|
||||
allow(ResolveAccountService).to receive(:new).and_return(service)
|
||||
|
||||
account.refresh!
|
||||
|
||||
expect(service).to_not have_received(:call).with(acct)
|
||||
end
|
||||
end
|
||||
|
||||
@@ -219,8 +223,12 @@ RSpec.describe Account do
|
||||
let(:domain) { 'example.com' }
|
||||
|
||||
it 'calls ResolveAccountService#call' do
|
||||
expect_any_instance_of(ResolveAccountService).to receive(:call).with(acct).once
|
||||
service = instance_double(ResolveAccountService, call: nil)
|
||||
allow(ResolveAccountService).to receive(:new).and_return(service)
|
||||
|
||||
account.refresh!
|
||||
|
||||
expect(service).to have_received(:call).with(acct).once
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
@@ -52,7 +52,8 @@ RSpec.describe Setting do
|
||||
before do
|
||||
allow(RailsSettings::Settings).to receive(:object).with(key).and_return(object)
|
||||
allow(described_class).to receive(:default_settings).and_return(default_settings)
|
||||
allow_any_instance_of(Settings::ScopedSettings).to receive(:thing_scoped).and_return(records)
|
||||
settings_double = instance_double(Settings::ScopedSettings, thing_scoped: records)
|
||||
allow(Settings::ScopedSettings).to receive(:new).and_return(settings_double)
|
||||
Rails.cache.delete(cache_key)
|
||||
end
|
||||
|
||||
@@ -128,7 +129,8 @@ RSpec.describe Setting do
|
||||
|
||||
describe '.all_as_records' do
|
||||
before do
|
||||
allow_any_instance_of(Settings::ScopedSettings).to receive(:thing_scoped).and_return(records)
|
||||
settings_double = instance_double(Settings::ScopedSettings, thing_scoped: records)
|
||||
allow(Settings::ScopedSettings).to receive(:new).and_return(settings_double)
|
||||
allow(described_class).to receive(:default_settings).and_return(default_settings)
|
||||
end
|
||||
|
||||
|
||||
Reference in new issue
Block a user