diff --git a/app/javascript/flavours/glitch/features/about/components/rules.tsx b/app/javascript/flavours/glitch/features/about/components/rules.tsx index e922d884fa..d0f231d8c3 100644 --- a/app/javascript/flavours/glitch/features/about/components/rules.tsx +++ b/app/javascript/flavours/glitch/features/about/components/rules.tsx @@ -6,6 +6,7 @@ import { defineMessages, FormattedMessage, useIntl } from 'react-intl'; import { createSelector } from '@reduxjs/toolkit'; +import type { ApiRuleJSON } from '@/flavours/glitch/api_types/instance'; import type { SelectItem } from '@/flavours/glitch/components/dropdown_selector'; import { Select } from '@/flavours/glitch/components/form_fields'; import type { RootState } from '@/flavours/glitch/store'; @@ -104,13 +105,13 @@ export const RulesSection: FC = ({ isLoading = false }) => { defaultMessage='Language' /> - {localeOptions.map((option) => ( - ))} @@ -121,15 +122,10 @@ export const RulesSection: FC = ({ isLoading = false }) => { ); }; -const selectRules = (state: RootState) => { - const rules = state.server.server.item?.rules; - - if (!rules) { - return []; - } - - return rules; -}; +const selectRules = createSelector( + [(state: RootState) => state.server.server.item], + (item) => item?.rules ?? [], +); const rulesSelector = createSelector( [selectRules, (_state, locale: string) => locale], @@ -142,18 +138,19 @@ const rulesSelector = createSelector( return rule; } + const translatedRule: ApiRuleJSON = { ...rule }; const partialLocale = locale.split('-')[0]; if (partialLocale && translations[partialLocale]) { - rule.text = translations[partialLocale].text; - rule.hint = translations[partialLocale].hint; + translatedRule.text = translations[partialLocale].text; + translatedRule.hint = translations[partialLocale].hint; } if (translations[locale]) { - rule.text = translations[locale].text; - rule.hint = translations[locale].hint; + translatedRule.text = translations[locale].text; + translatedRule.hint = translations[locale].hint; } - return rule; + return translatedRule; }); }, );