Move filtered notifications bar in scrollable area (#30996)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
This commit is contained in:
		
							parent
							
								
									0b97ec3f7b
								
							
						
					
					
						commit
						9d0bce4072
					
				| @ -223,6 +223,13 @@ class Notifications extends PureComponent { | |||||||
| 
 | 
 | ||||||
|     let scrollContainer; |     let scrollContainer; | ||||||
| 
 | 
 | ||||||
|  |     const prepend = ( | ||||||
|  |       <> | ||||||
|  |         {needsNotificationPermission && <NotificationsPermissionBanner />} | ||||||
|  |         <FilteredNotificationsBanner /> | ||||||
|  |       </> | ||||||
|  |     ); | ||||||
|  | 
 | ||||||
|     if (signedIn) { |     if (signedIn) { | ||||||
|       scrollContainer = ( |       scrollContainer = ( | ||||||
|         <ScrollableList |         <ScrollableList | ||||||
| @ -232,7 +239,7 @@ class Notifications extends PureComponent { | |||||||
|           showLoading={isLoading && notifications.size === 0} |           showLoading={isLoading && notifications.size === 0} | ||||||
|           hasMore={hasMore} |           hasMore={hasMore} | ||||||
|           numPending={numPending} |           numPending={numPending} | ||||||
|           prepend={needsNotificationPermission && <NotificationsPermissionBanner />} |           prepend={prepend} | ||||||
|           alwaysPrepend |           alwaysPrepend | ||||||
|           emptyMessage={emptyMessage} |           emptyMessage={emptyMessage} | ||||||
|           onLoadMore={this.handleLoadOlder} |           onLoadMore={this.handleLoadOlder} | ||||||
| @ -282,8 +289,6 @@ class Notifications extends PureComponent { | |||||||
| 
 | 
 | ||||||
|         {filterBarContainer} |         {filterBarContainer} | ||||||
| 
 | 
 | ||||||
|         <FilteredNotificationsBanner /> |  | ||||||
| 
 |  | ||||||
|         {scrollContainer} |         {scrollContainer} | ||||||
| 
 | 
 | ||||||
|         <Helmet> |         <Helmet> | ||||||
|  | |||||||
| @ -10192,8 +10192,7 @@ noscript { | |||||||
| .filtered-notifications-banner { | .filtered-notifications-banner { | ||||||
|   display: flex; |   display: flex; | ||||||
|   align-items: center; |   align-items: center; | ||||||
|   border: 1px solid var(--background-border-color); |   border-bottom: 1px solid var(--background-border-color); | ||||||
|   border-top: 0; |  | ||||||
|   padding: 24px 32px; |   padding: 24px 32px; | ||||||
|   gap: 16px; |   gap: 16px; | ||||||
|   color: $darker-text-color; |   color: $darker-text-color; | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user