tarrien/Mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(components/autosuggest_textarea): Race condition regarding onBlur (#3631)

Browse Source
This commit is contained in:
Sorin Davidoi 2017-06-07 20:05:53 +02:00 committed by Eugen Rochko
parent 0f1b1d78b1
commit 8cf8ce4ac0
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/javascript/mastodon/components/autosuggest_textarea.js
View File

@ -124,13 +124,7 @@ class AutosuggestTextarea extends ImmutablePureComponent {
} }
onBlur = () => { onBlur = () => {
// If we hide the suggestions immediately, then this will prevent the this.setState({ suggestionsHidden: true });
// onClick for the suggestions themselves from firing.
// Setting a short window for that to take place before hiding the
// suggestions ensures that can't happen.
setTimeout(() => {
this.setState({ suggestionsHidden: true });
}, 100);
} }
onSuggestionClick = (e) => { onSuggestionClick = (e) => {
@ -191,7 +185,7 @@ class AutosuggestTextarea extends ImmutablePureComponent {
key={suggestion} key={suggestion}
data-index={suggestion} data-index={suggestion}
className={`autosuggest-textarea__suggestions__item ${i === selectedSuggestion ? 'selected' : ''}`} className={`autosuggest-textarea__suggestions__item ${i === selectedSuggestion ? 'selected' : ''}`}
onClick={this.onSuggestionClick} onMouseDown={this.onSuggestionClick}
> >
<AutosuggestAccountContainer id={suggestion} /> <AutosuggestAccountContainer id={suggestion} />
</div> </div>