tarrien/Mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add details to JS browser error spec failure helpers (#37441)

Browse Source
This commit is contained in:
Matt Jankowski 2026-01-12 04:38:00 -05:00 committed by GitHub
parent a9cfddf28e
commit 0fb4e26cfe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/support/browser_errors.rb
View File

@ -4,6 +4,10 @@ module BrowserErrorsHelpers
def ignore_js_error(error) def ignore_js_error(error)
@ignored_js_errors_for_spec << error @ignored_js_errors_for_spec << error
end end
def error_message(error)
error.keys.map { |key| "#{key.to_s.titleize}: #{error[key]}" }.join("\n")
end
end end
RSpec.configure do |config| RSpec.configure do |config|
@ -15,7 +19,7 @@ RSpec.configure do |config|
example.metadata[:js_console_messages] ||= [] example.metadata[:js_console_messages] ||= []
Capybara.current_session.driver.with_playwright_page do |page| Capybara.current_session.driver.with_playwright_page do |page|
page.on('console', lambda { |msg| page.on('console', lambda { |msg|
example.metadata[:js_console_messages] << { type: msg.type, text: msg.text, location: msg.location } example.metadata[:js_console_messages] << { type: msg.type, text: msg.text, location: msg.location, page: msg.page.url }
}) })
end end
end end
@ -34,7 +38,7 @@ RSpec.configure do |config|
if errors.present? if errors.present?
aggregate_failures 'browser errrors' do aggregate_failures 'browser errrors' do
errors.each do |error| errors.each do |error|
expect(error[:type]).to_not eq('error'), error[:text] expect(error[:type]).to_not eq('error'), error_message(error)
next unless error[:type] == 'warning' next unless error[:type] == 'warning'
warn 'WARN: browser warning' warn 'WARN: browser warning'